Help! Help with playerlist

[libModz]

Hey guys, I have a playerlist but it only shows players names correctly with 6 or more characters in their nickname, players with 5 or less characters show as weird symbols, I think it has something to do with my monoString struct and the way it converts, but no idea how to fix. Any help appreciated, thanks

typedef struct _monoString
{
    void *player;
    int id;
    void *photonView;
    char chars[1];
    void PhotonViewInfo(void *player, int id, void *photonView);
    const char* getString()
    {
        std::u16string u16string(reinterpret_cast<const char16_t *>(chars));
        std::wstring wstring(u16string.begin(), u16string.end());
        std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> convert;

        return convert.to_bytes(wstring).c_str();
    }
        std::string stdgetString()
    {
        std::u16string u16string(reinterpret_cast<const char16_t *>(chars));
        std::wstring wstring(u16string.begin(), u16string.end());
        std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> convert;

        return convert.to_bytes(wstring);
    }
    char* getRawChars()
    {
        return chars;
    }
    }

 

[mIsmanXP]

Are you using `getString` or `stdgetString`?

If you're using `getString`, the object that holds the `char*` is destroyed when you leave the function.
it may display garbage if the character count is less than 5. However, when the character count is more than 5 or 6, the characters are stored on the heap and remain intact even when you leave the function.

 

[mIsmanXP]

The simple fix is to get the std::string and do c_str on it

 

[libModz]

The simple fix is to get the std::string and do c_str on it

Can you show me how? I think I'm using stdgetString

 

[mIsmanXP]

instead of getString(), use getstdString().c_str

 

[libModz]

instead of getString(), use getstdString().c_str

Sorry I'm a noob, can you show me in the code where I need to change it.

 

[mIsmanXP]

Are you using getString to get the name or what?
How are you showing the name?

 

[libModz]

I'm not sure, I didn't make the code myself.

if (PhotonNetwork_get_player!=nullptr) {
    auto playerlist = PhotonNetwork_get_otherPlayers();
    for (int i = 0; i < playerlist->getLength(); ++i) {
        auto players = playerlist->getPointer()[i];
        if (players != NULL) {
            env->SetObjectArrayElement(playerNames, i+1,
            env->NewStringUTF(PlayerExtensions_GetNickname(players)->getString()));
        }
    }
}
return playerNames;
}

 

[libModz]

if(PhotonPlayer!=nullptr) {
                        monoString *playername = PlayerExtensions_GetNickname(PhotonPlayer);
                        if(playername->stdgetString().compare(PlayerListKick) == 0) {
                            PhotonNetwork_CloseConnection(PhotonPlayer);

 

[libModz]

Nevermind I've fixed it. Thanks so much!

 

[mIsmanXP]

I'm not sure, I didn't make the code myself.

if (PhotonNetwork_get_player!=nullptr) {
    auto playerlist = PhotonNetwork_get_otherPlayers();
    for (int i = 0; i < playerlist->getLength(); ++i) {
        auto players = playerlist->getPointer()[i];
        if (players != NULL) {
            env->SetObjectArrayElement(playerNames, i+1,
            env->NewStringUTF(PlayerExtensions_GetNickname(players)->getString()));
        }
    }
}
return playerNames;
}

There, replace getString with getstdString().c_str()

Edit* alright, didn't see your post before posting this

 

[libModz]

There, replace getString with getstdString().c_str()

Edit* alright, didn't see your post before posting this

Lol cheers